Skip to content

[Refactor:Developer] Replace submitty_count#56

Draft
dagemcn wants to merge 6 commits into
mainfrom
remove_submitty_count
Draft

[Refactor:Developer] Replace submitty_count#56
dagemcn wants to merge 6 commits into
mainfrom
remove_submitty_count

Conversation

@dagemcn

@dagemcn dagemcn commented Jun 29, 2026

Copy link
Copy Markdown
Member

What is the current behavior?

Fixes Submitty Issue#11784 - This one of the companion PRs to Submitty PR#12609.
The tutorial courses 04 - Python Static Analysis, 06 - Loop Types, and 07 - Loop Depth all use submitty_count in their autograding configs. This command is being deprecated, so we should update it.

What is the new behavior?

submitty_count has been removed from 04 - Python Static Analysis and 06 - Loop Types and replaced with submitty_count_ts in preparation for deprecation. For 07 - Loop Depth, there was no equivalent functionality present in submitty_count_ts so the testcase is entirely commented out.

Other information?

This specific PR is not a breaking change. However, the other PRs accompanying this one are breaking PRs.

Tested that all homework configs still build and their accompanying still submissions work as intended.

@github-project-automation github-project-automation Bot moved this to Seeking Reviewer in Submitty Development Jun 29, 2026
@dagemcn dagemcn changed the title Replace submitty_count with submitty_count_ts [Refactor:Developer] Replace submitty_count with submitty_count_ts Jun 29, 2026
@dagemcn dagemcn changed the title [Refactor:Developer] Replace submitty_count with submitty_count_ts [Refactor:Developer] Replace submitty_count Jun 29, 2026
@roye2 roye2 self-requested a review July 8, 2026 19:17

@roye2 roye2 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noted some small fixes that need to be made.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am concerned that anything testing this gradeable will be expecting autograding results. But, it does look like the cypress spec 'verify_tutorial_courses' only checks if you can submit, so it should be fine.

Comment thread examples/06_loop_types/config/config.json
Comment thread examples/04_python_static_analysis/config/config.json
@github-project-automation github-project-automation Bot moved this from Seeking Reviewer to Work in Progress in Submitty Development Jul 8, 2026
@roye2 roye2 self-requested a review July 10, 2026 13:39

@roye2 roye2 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested all 3 gradeables affected by this change. 04 python static analysis and 06 loop types look good and behave the same way before and after the changes from this PR. As for 07 loop depth, we will just need to make sure that turning off autograding for it doesn't break any testing or anything.

@github-project-automation github-project-automation Bot moved this from Work in Progress to Awaiting Maintainer Review in Submitty Development Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Awaiting Maintainer Review

Development

Successfully merging this pull request may close these issues.

2 participants